[webkit-changes] [WebKit/WebKit] 87496b: [UI-side compositing] Create RemoteScrollbarsContr...

Nikos Mouchtaris noreply at github.com
Fri Apr 7 18:42:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 87496bbd2fe0644663cbe1fb501e2711eddae3c3
      https://github.com/WebKit/WebKit/commit/87496bbd2fe0644663cbe1fb501e2711eddae3c3
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-04-07 (Fri, 07 Apr 2023)

  Changed paths:
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
    M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
    M Source/WebCore/page/scrolling/ScrollingCoordinator.h
    M Source/WebCore/platform/ScrollbarsController.h
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    A Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.cpp
    A Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h

  Log Message:
  -----------
  [UI-side compositing] Create RemoteScrollbarsController for plumbing web process events to the scrolling coordinator
https://bugs.webkit.org/show_bug.cgi?id=255173
rdar://107770765

Reviewed by Simon Fraser.

This patch creates RemoteScrollbarsController, for the purpose of moving the scrolling coordinator
calls out of EventHandler and into the ScrollbarController functions, which were already being
called in the EventHandler.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::notifyScrollableAreasOfMouseEvents):
(WebCore::EventHandler::updateLastScrollbarUnderMouse):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::setMouseIsOverContentArea):
(WebCore::AsyncScrollingCoordinator::setMouseMovedInContentArea):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:
* Source/WebCore/page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::setMouseIsOverContentArea):
(WebCore::ScrollingCoordinator::setMouseMovedInContentArea):
* Source/WebCore/platform/ScrollbarsController.h:
(WebCore::ScrollbarsController::contentAreaWillPaint const):
(WebCore::ScrollbarsController::mouseEnteredContentArea):
(WebCore::ScrollbarsController::mouseExitedContentArea):
(WebCore::ScrollbarsController::mouseMovedInContentArea):
(WebCore::ScrollbarsController::mouseEnteredScrollbar const):
(WebCore::ScrollbarsController::mouseExitedScrollbar const):
(WebCore::ScrollbarsController::mouseIsDownInScrollbar const):
(WebCore::ScrollbarsController::willStartLiveResize):
(WebCore::ScrollbarsController::contentsSizeChanged const):
(WebCore::ScrollbarsController::willEndLiveResize):
(WebCore::ScrollbarsController::contentAreaDidShow):
(WebCore::ScrollbarsController::contentAreaDidHide):
(WebCore::ScrollbarsController::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollbarsController::scrollbarsCanBeActive const):
(WebCore::ScrollbarsController::didAddVerticalScrollbar):
(WebCore::ScrollbarsController::willRemoveVerticalScrollbar):
(WebCore::ScrollbarsController::didAddHorizontalScrollbar):
(WebCore::ScrollbarsController::willRemoveHorizontalScrollbar):
(WebCore::ScrollbarsController::invalidateScrollbarPartLayers):
(WebCore::ScrollbarsController::verticalScrollbarLayerDidChange):
(WebCore::ScrollbarsController::horizontalScrollbarLayerDidChange):
(WebCore::ScrollbarsController::shouldScrollbarParticipateInHitTesting):
(WebCore::ScrollbarsController::horizontalScrollbarStateForTesting const):
(WebCore::ScrollbarsController::verticalScrollbarStateForTesting const):
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createScrollingCoordinator const):
(WebKit::WebChromeClient::createScrollbarsController const):
* Source/WebKit/WebProcess/WebPage/mac/ScrollbarsControllerProxyMac.cpp: Added.
(WebKit::ScrollbarsControllerProxyMac::ScrollbarsControllerProxyMac):
(WebKit::ScrollbarsControllerProxyMac::mouseEnteredContentArea):
(WebKit::ScrollbarsControllerProxyMac::mouseExitedContentArea):
(WebKit::ScrollbarsControllerProxyMac::mouseMovedInContentArea):
(WebKit::ScrollbarsControllerProxyMac::mouseEnteredScrollbar const):
(WebKit::ScrollbarsControllerProxyMac::mouseExitedScrollbar const):
* Source/WebKit/WebProcess/WebPage/mac/ScrollbarsControllerProxyMac.h: Added.

Canonical link: https://commits.webkit.org/262744@main




More information about the webkit-changes mailing list