[webkit-changes] [WebKit/WebKit] b59023: [iOS] fast/forms/caps-lock-indicator-width.html is...

Aditya Keerthi noreply at github.com
Fri Apr 7 19:37:42 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b590236e7198d5c30c9d628c0b8830d5a1036f1f
      https://github.com/WebKit/WebKit/commit/b590236e7198d5c30c9d628c0b8830d5a1036f1f
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2023-04-07 (Fri, 07 Apr 2023)

  Changed paths:
    M Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm

  Log Message:
  -----------
  [iOS] fast/forms/caps-lock-indicator-width.html is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=255168
rdar://107730715

Reviewed by Wenson Hsieh.

WebKit uses an internal UIKit method to set modifier flags on a `UIPhysicalKeyboardEvent`.
However, UIKit has renamed the setter to better match Objective-C convention. This
results in a crash due to an unrecognized selector.

* Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::setModifierFlagsForUIPhysicalKeyboardEvent):

Use the new selector where possible.

(WTR::createUIPhysicalKeyboardEvent):

Canonical link: https://commits.webkit.org/262745@main




More information about the webkit-changes mailing list