[webkit-changes] [WebKit/WebKit] 77d05a: REGRESSION (macOS 13.3): Holding down-arrow beeps ...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77d05a5a85fdd306862c249bd0b8429baaf6bc4d
      https://github.com/WebKit/WebKit/commit/77d05a5a85fdd306862c249bd0b8429baaf6bc4d
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-04-07 (Fri, 07 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/KeyboardScrollingAnimator.cpp
    M Tools/TestWebKitAPI/Tests/mac/KeyboardEventTests.mm

  Log Message:
  -----------
  REGRESSION (macOS 13.3): Holding down-arrow beeps while scrolling before reaching end of document in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=255039
rdar://107667589

Reviewed by Aditya Keerthi.

This was happening because the keyboard event is considered "unhandled" if the triggering key is
already held down.

This PR fixes this by simply correcting this behavior, since these events should actually be
considered "handled".

* Source/WebCore/platform/KeyboardScrollingAnimator.cpp:
(WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture):
* Tools/TestWebKitAPI/Tests/mac/KeyboardEventTests.mm:
(-[NSViewWithKeyDownOverride keyDown:]):
(TestWebKitAPI::arrowKeyDownWithKeyRepeat):
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/262743@main