[webkit-changes] [WebKit/WebKit] 394f41: Don't unnecessarily tear down top layer renderers ...

Tim Nguyen noreply at github.com
Wed Oct 19 08:15:28 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 394f41a9f855821c56434f4eb70cdb871dd9ad98
      https://github.com/WebKit/WebKit/commit/394f41a9f855821c56434f4eb70cdb871dd9ad98
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp

  Log Message:
  -----------
  Don't unnecessarily tear down top layer renderers in RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=246735
rdar://101324926

Reviewed by Antti Koivisto.

The element.isInTopLayer() check added by https://commits.webkit.org/246767@main is there is because
entering top layer forces `display: contents` style to `display: block`. This check is now redundant
with https://commits.webkit.org/255527@main, since it is fixing the same issue more globally.

Test: fast/css/top-layer-display-contents-crash.html

* Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateElementRenderer):

Canonical link: https://commits.webkit.org/255733@main




More information about the webkit-changes mailing list