[webkit-changes] [WebKit/WebKit] 11e75f: Add an `isThirdParty` argument when calling into `...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 11e75f8501ba2d377ca928f0bef4a02872ce0abc
      https://github.com/WebKit/WebKit/commit/11e75f8501ba2d377ca928f0bef4a02872ce0abc
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Source/WebCore/platform/network/ResourceRequestBase.cpp
    M Source/WebCore/platform/network/ResourceRequestBase.h
    M Source/WebKit/NetworkProcess/NetworkDataTask.cpp
    M Source/WebKit/NetworkProcess/NetworkDataTask.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h
    M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
    M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

  Log Message:
  -----------
  Add an `isThirdParty` argument when calling into `enableNetworkConnectionIntegrity`
https://bugs.webkit.org/show_bug.cgi?id=246722
rdar://101316400

Reviewed by Youenn Fablet.

Refactor some code that calls into `enableNetworkConnectionIntegrity`, such that we also pass in
whether or not the resource request is third party. See below for more details.

* Source/WebCore/platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::isThirdParty const):

Move `NetworkDataTask::isThirdPartyRequest(const ResourceRequest&)` down into `ResourceRequestBase`
as a const method, so that we don't need to reach into `NetworkDataTask` in order to perform this
check.

* Source/WebCore/platform/network/ResourceRequestBase.h:
* Source/WebKit/NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::restrictRequestReferrerToOriginIfNeeded):
(WebKit::NetworkDataTask::isThirdPartyRequest const): Deleted.

Moved to `ResourceRequestBase` (see above).

* Source/WebKit/NetworkProcess/NetworkDataTask.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::enableNetworkConnectionIntegrity):

Add a boolean argument to represent whether or not the request is third party.

(WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):

Adopt the `isThirdParty()` method.

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::createWebSocketTask):

Pass in whether or not the given request is third party.

Canonical link: https://commits.webkit.org/255734@main