[webkit-changes] [WebKit/WebKit] 3f0b2f: Displayed text link uses matched group 1 while gen...

Ling Ho noreply at github.com
Wed Oct 19 08:13:24 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f0b2fe64691154a33e6aa83027d5d9a4ef4e7bd
      https://github.com/WebKit/WebKit/commit/3f0b2fe64691154a33e6aa83027d5d9a4ef4e7bd
  Author: Ling Ho <lingho at apple.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Websites/bugs.webkit.org/extensions/Commits/Extension.pm

  Log Message:
  -----------
  Displayed text link uses matched group 1 while generate link uses matched group 2 due to another regex handing trac.webkit.org link.
https://bugs.webkit.org/show_bug.cgi?id=246692
rdar://problem/101297471

Reviewed by Jonathan Bedard.

* Websites/bugs.webkit.org/extensions/Commits/Extension.pm:
(bug_format_comment):

sub _replace_reference {
    my $args = shift;
    my $text = $args->{matches}->[0];
    my $reference = $args->{matches}->[1];
    return qq{<a href="https://commits.webkit.org/$reference">$text</a>};
};
My last patch left out a parentesis pair causing group 2 to be NULL.

Canonical link: https://commits.webkit.org/255732@main




More information about the webkit-changes mailing list