[webkit-changes] [WebKit/WebKit] 2065c2: [iOS] Flaky crash under ScreenOrientationProvider:...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2065c26bcce50d3cca791ffe95229237895ad79e
      https://github.com/WebKit/WebKit/commit/2065c26bcce50d3cca791ffe95229237895ad79e
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    M Source/WebCore/platform/ScreenOrientationProvider.cpp
    M Source/WebCore/platform/ScreenOrientationProvider.h
    M Source/WebCore/platform/ios/ScreenOrientationProviderIOS.mm

  Log Message:
  -----------
  [iOS] Flaky crash under ScreenOrientationProvider::screenOrientationDidChange()
https://bugs.webkit.org/show_bug.cgi?id=248632
rdar://102697580

Reviewed by Wenson Hsieh.

ScreenOrientationProvider::platformStopListeningForChanges() was clearing
m_systemObserver without clearing the system's observer's pointer to the
provider. Upon destruction, ScreenOrientationProvider::platformDestroy() would
attempt to clear this pointer but it wouldn't work in the case where
platformStopListeningForChanges() was previously called, since m_systemObserver
is already gone.

* Source/WebCore/platform/ScreenOrientationProvider.cpp:
(WebCore::ScreenOrientationProvider::~ScreenOrientationProvider):
(WebCore::ScreenOrientationProvider::platformStopListeningForChanges):
(WebCore::ScreenOrientationProvider::platformDestroy): Deleted.
* Source/WebCore/platform/ScreenOrientationProvider.h:
* Source/WebCore/platform/ios/ScreenOrientationProviderIOS.mm:
(WebCore::ScreenOrientationProvider::platformStopListeningForChanges):
(WebCore::ScreenOrientationProvider::platformDestroy): Deleted.

Canonical link: https://commits.webkit.org/257303@main