[webkit-changes] [WebKit/WebKit] 1a3a9c: Soundcloud.com Login Issue

Chris Dumez noreply at github.com
Fri Dec 2 12:12:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a3a9cb3d50d3a5c9db6b3fe5c47b72df56c1bce
      https://github.com/WebKit/WebKit/commit/1a3a9cb3d50d3a5c9db6b3fe5c47b72df56c1bce
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp

  Log Message:
  -----------
  Soundcloud.com Login Issue
https://bugs.webkit.org/show_bug.cgi?id=248629

Reviewed by Sihui Liu.

Add Soundcloud.com to the list of sites where we need to turn on the
showModalDialog quirk to avoid breaking login.

With the quirk, the showModalDialog property exists but its value is
undefined. Like for the other sites, this is sufficient to restore
functionality. Those sites seem to check that the property exists for
some reason.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldExposeShowModalDialog const):

Canonical link: https://commits.webkit.org/257302@main




More information about the webkit-changes mailing list