[webkit-changes] [WebKit/WebKit] 298c6a: [ews-build.webkit.org] Skip deleted PRs
Jonathan Bedard
noreply at github.com
Fri Dec 2 12:22:27 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 298c6a0c5b1073fb257d385a8b8d73edb69a312b
https://github.com/WebKit/WebKit/commit/298c6a0c5b1073fb257d385a8b8d73edb69a312b
Author: Jonathan Bedard <jbedard at apple.com>
Date: 2022-12-02 (Fri, 02 Dec 2022)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[ews-build.webkit.org] Skip deleted PRs
https://bugs.webkit.org/show_bug.cgi?id=248661
rdar://102906047
Reviewed by Aakash Jain.
If GitHub returns a 400, that usually means the PR in question has been deleted, which
is very similar to a closed PR or an outdated hash.
* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.fetch_data_from_url_with_authentication_github): Return 'False' for 400 responses.
(GitHubMixin.get_pr_json): Return 'False' if the GitHub call returns a 400 response.
(GitHubMixin._is_pr_closed):
(GitHubMixin._is_hash_outdated):
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/257304@main
More information about the webkit-changes
mailing list