[webkit-changes] cvs commit: WebCore/khtml/xml dom_docimpl.cpp

Adele adele at opensource.apple.com
Tue Jul 12 18:02:35 PDT 2005


adele       05/07/12 18:02:35

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml/xml Tag: Safari-2-0-branch dom_docimpl.cpp
  Log:
          Merged fix from TOT to Safari-2-0-branch
          <rdar://problem/4176180>
  
      2005-07-07  Adele Peterson  <adele at apple.com>
  
          change by Maciej, reviewed by me.
  
          fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)
  
          No test cases added.  There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
          called twice for the same document, and this can cause some nodes to unnecessarily remain in the
          m_disconnectedNodesWithEventListeners list.  This fix just clears the m_disconnectedNodesWithEventListeners
          list after removing all event listeners for the disconnected nodes.
  
          * khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4104.2.62 +18 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4104.2.61
  retrieving revision 1.4104.2.62
  diff -u -r1.4104.2.61 -r1.4104.2.62
  --- ChangeLog	12 Jul 2005 22:28:09 -0000	1.4104.2.61
  +++ ChangeLog	13 Jul 2005 01:02:27 -0000	1.4104.2.62
  @@ -1,6 +1,24 @@
   2005-07-12  Adele Peterson  <adele at apple.com>
   
           Merged fix from TOT to Safari-2-0-branch
  +        <rdar://problem/4176180>
  +
  +    2005-07-07  Adele Peterson  <adele at apple.com>
  +
  +        change by Maciej, reviewed by me.
  +
  +        fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)
  +
  +        No test cases added.  There are some edge cases in which removeAllDisconnectedNodeEventListeners can get 
  +        called twice for the same document, and this can cause some nodes to unnecessarily remain in the 
  +        m_disconnectedNodesWithEventListeners list.  This fix just clears the m_disconnectedNodesWithEventListeners 
  +        list after removing all event listeners for the disconnected nodes.
  +
  +        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
  +
  +2005-07-12  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
           <rdar://problem/4164978>
   
       2005-06-24  Darin Adler  <darin at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.211.6.8 +1 -0      WebCore/khtml/xml/dom_docimpl.cpp
  
  Index: dom_docimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_docimpl.cpp,v
  retrieving revision 1.211.6.7
  retrieving revision 1.211.6.8
  diff -u -r1.211.6.7 -r1.211.6.8
  --- dom_docimpl.cpp	12 Jul 2005 21:16:35 -0000	1.211.6.7
  +++ dom_docimpl.cpp	13 Jul 2005 01:02:34 -0000	1.211.6.8
  @@ -1312,6 +1312,7 @@
            ++iter) {
           iter.current()->removeAllEventListeners();
       }
  +    m_disconnectedNodesWithEventListeners.clear();
   }
   
   #if APPLE_CHANGES
  
  
  



More information about the webkit-changes mailing list