[webkit-changes] cvs commit: WebCore/khtml/xml dom_docimpl.cpp

[Adele]

adele       05/07/12 18:01:25

  Modified:    .        Tag: Safari-1-3-branch ChangeLog
               khtml/xml Tag: Safari-1-3-branch dom_docimpl.cpp
  Log:
          Merged fix from TOT to Safari-1-3-branch
          <rdar://problem/4176180>
  
      2005-07-07  Adele Peterson  <adele at apple.com>
  
          change by Maciej, reviewed by me.
  
          fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)
  
          No test cases added.  There are some edge cases in which removeAllDisconnectedNodeEventListeners can get
          called twice for the same document, and this can cause some nodes to unnecessarily remain in the
          m_disconnectedNodesWithEventListeners list.  This fix just clears the m_disconnectedNodesWithEventListeners
          list after removing all event listeners for the disconnected nodes.
  
          * khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4108.4.36 +18 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4108.4.35
  retrieving revision 1.4108.4.36
  diff -u -r1.4108.4.35 -r1.4108.4.36
  --- ChangeLog	13 Jul 2005 00:56:50 -0000	1.4108.4.35
  +++ ChangeLog	13 Jul 2005 01:01:18 -0000	1.4108.4.36
  @@ -1,5 +1,23 @@
   2005-07-12  Adele Peterson  <adele at apple.com>
   
  +        Merged fix from TOT to Safari-1-3-branch
  +        <rdar://problem/4176180>
  +
  +    2005-07-07  Adele Peterson  <adele at apple.com>
  +
  +        change by Maciej, reviewed by me.
  +
  +        fix for <rdar://problem/4168001> Cambridge 8C45: Safari crashes in Webcore (DOM::NodeImpl::removeAllEventListeners() + 32)
  +
  +        No test cases added.  There are some edge cases in which removeAllDisconnectedNodeEventListeners can get 
  +        called twice for the same document, and this can cause some nodes to unnecessarily remain in the 
  +        m_disconnectedNodesWithEventListeners list.  This fix just clears the m_disconnectedNodesWithEventListeners 
  +        list after removing all event listeners for the disconnected nodes.
  +
  +        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::removeAllDisconnectedNodeEventListeners):
  +
  +2005-07-12  Adele Peterson  <adele at apple.com>
  +
           Merged WebCore part of fix from TOT to Safari-1-3-branch
           <rdar://problem/4176173>
   
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.211.4.6 +1 -0      WebCore/khtml/xml/dom_docimpl.cpp
  
  Index: dom_docimpl.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/xml/dom_docimpl.cpp,v
  retrieving revision 1.211.4.5
  retrieving revision 1.211.4.6
  diff -u -r1.211.4.5 -r1.211.4.6
  --- dom_docimpl.cpp	12 Jul 2005 22:38:00 -0000	1.211.4.5
  +++ dom_docimpl.cpp	13 Jul 2005 01:01:24 -0000	1.211.4.6
  @@ -1305,6 +1305,7 @@
            ++iter) {
           iter.current()->removeAllEventListeners();
       }
  +    m_disconnectedNodesWithEventListeners.clear();
   }
   
   #if APPLE_CHANGES