[webkit-changes] cvs commit: WebCore/khtml khtml_part.cpp

[Adele]

adele       05/07/12 18:07:30

  Modified:    .        Tag: Safari-2-0-branch ChangeLog
               khtml    Tag: Safari-2-0-branch khtml_part.cpp
  Log:
          Merged fix from TOT to Safari-2-0-branch
          <rdar://problem/4178198>
  
      2005-07-12  Kevin Decker  <kdecker at apple.com>
  
           Reviewed by cblu.
  
  	Fixed:
  	  http://bugzilla.opendarwin.org/show_bug.cgi?id=3968
  	 <rdar://problem/4172645> REGRESSION: top frame only loads at banking site - http://www.skandiabanken.no
  
          Test cases added: None; This fixes a race condition that is not reproducible locally.
  
          * khtml/khtml_part.cpp:
          (KHTMLPart::scheduleLocationChange): If a redirect was scheduled during a load, then stop the current load. Otherwise when the current load transitions from a provisional to a committed state, pending redirects may be cancelled.
          (KHTMLPart::scheduleLocationChange):
  
  Revision  Changes    Path
  No                   revision
  
  
  No                   revision
  
  
  1.4104.2.63 +19 -0     WebCore/ChangeLog
  
  Index: ChangeLog
  ===================================================================
  RCS file: /cvs/root/WebCore/ChangeLog,v
  retrieving revision 1.4104.2.62
  retrieving revision 1.4104.2.63
  diff -u -r1.4104.2.62 -r1.4104.2.63
  --- ChangeLog	13 Jul 2005 01:02:27 -0000	1.4104.2.62
  +++ ChangeLog	13 Jul 2005 01:07:19 -0000	1.4104.2.63
  @@ -1,6 +1,25 @@
   2005-07-12  Adele Peterson  <adele at apple.com>
   
           Merged fix from TOT to Safari-2-0-branch
  +        <rdar://problem/4178198>
  +
  +    2005-07-12  Kevin Decker  <kdecker at apple.com>
  +
  +         Reviewed by cblu.
  +
  +	Fixed: 
  +	  http://bugzilla.opendarwin.org/show_bug.cgi?id=3968
  +	 <rdar://problem/4172645> REGRESSION: top frame only loads at banking site - http://www.skandiabanken.no
  +
  +        Test cases added: None; This fixes a race condition that is not reproducible locally.
  +
  +        * khtml/khtml_part.cpp:
  +        (KHTMLPart::scheduleLocationChange): If a redirect was scheduled during a load, then stop the current load. Otherwise when the current load transitions from a provisional to a committed state, pending redirects may be cancelled. 
  +        (KHTMLPart::scheduleLocationChange):
  +
  +2005-07-12  Adele Peterson  <adele at apple.com>
  +
  +        Merged fix from TOT to Safari-2-0-branch
           <rdar://problem/4176180>
   
       2005-07-07  Adele Peterson  <adele at apple.com>
  
  
  
  No                   revision
  
  
  No                   revision
  
  
  1.311.8.8 +8 -0      WebCore/khtml/khtml_part.cpp
  
  Index: khtml_part.cpp
  ===================================================================
  RCS file: /cvs/root/WebCore/khtml/khtml_part.cpp,v
  retrieving revision 1.311.8.7
  retrieving revision 1.311.8.8
  diff -u -r1.311.8.7 -r1.311.8.8
  --- khtml_part.cpp	2 Jul 2005 01:42:40 -0000	1.311.8.7
  +++ khtml_part.cpp	13 Jul 2005 01:07:29 -0000	1.311.8.8
  @@ -2051,6 +2051,14 @@
       // Handle a location change of a page with no document as a special case.
       // This may happen when a frame changes the location of another frame.
       d->m_scheduledRedirection = d->m_doc ? locationChangeScheduled : locationChangeScheduledDuringLoad;
  +    
  +    // If a redirect was scheduled during a load, then stop the current load.
  +    // Otherwise when the current load transitions from a provisional to a 
  +    // committed state, pending redirects may be cancelled. 
  +    if (locationChangeScheduledDuringLoad) {
  +        stopLoading(true);   
  +    }
  +    
       d->m_delayRedirect = 0;
       d->m_redirectURL = url;
       d->m_redirectReferrer = referrer;