- webkit-efl - lists.webkit.org

Fwd: Re: Re: Re: I want to change *.c to *.cpp
by Ryuan Choi 23 Sep '11

23 Sep '11

> I thought you would change all *.c and not just ewk_view_single.c and > ewk_view_tiled.c. I'd like to share patch to fix above issue. Now I'm waiting internal review for it. There are build break issues, so that I tried to not only rename but also fix breaks, pointer operator and cast. BTW, I realize that EINA_INLIST_FOREACH make build break with cpp. For now, I redefine EINA_INLIST_FOREACH. Should we need to fix it? Best Regards, Ryuan Choi

1 0

Change C-casting with C++ casting
by Gyuyoung Kim 22 Sep '11

22 Sep '11

Hello Lucas, Thank you for your patch on Bug 68231. I think patch owner is going to submit new patch based on latest WebKit again. BTW, I think our next item is to replace C-casting with C++ casting in .cpp files. (https://bugs.webkit.org/show_bug.cgi?id=68321) I wonder if your script can change them automatically. If your script can do it, I think it is better to use it. But, it can't do that, I'd like to get a review for attached patch. Gyuyoung Kim

2 2

[HEADS-UP] Patches probably broken
by Lucas De Marchi 21 Sep '11

21 Sep '11

Hey, As part of the coding-style cleanup task I landed today a patch to change "type *ptr" to "type* ptr". This probably broke a great part of the patches pending on bugzilla. If you care about them, please make sure to check if they still apply to tot. Sorry for this, but it was necessary. If a patch is not updated and it doesn't apply anymore, probably no one cares and we should close the bug, right? So, make sure to update the patches on bugzilla if you want them to be eventually applied. In other words, don't wait the commit bot saying your patch could not be applied anymore, ok? regards, Lucas De Marchi

1 0

Re: [webkit-efl] I want to change *.c to *.cpp
by Ryuan Choi 21 Sep '11

21 Sep '11

> I thought you would change all *.c and not just ewk_view_single.c and > ewk_view_tiled.c. Sure, I'll create new bug for them. Regards, Ryuan Choi

1 0

Re: [webkit-efl] I want to change *.c to *.cpp
by Ryuan Choi 21 Sep '11

21 Sep '11

> On Mon, Aug 15, 2011 at 11:23 PM, Ryuan Choi wrote: > > Hello, WebKit/EFL guys. > > > > Could anyone know why we use *.c like ewk_view_single.c and ewk_view_tiled.c? > > Did you create a bug report for this? > > Lucas De Marchi It was already merged. ( https://bugs.webkit.org/show_bug.cgi?id=66542 ) Anyway, we should change other c files to cpp. Thanks. +------------------------------------------------------------------------ Listen and listen and listen -----------------------+

2 1

I want to change *.c to *.cpp
by Ryuan Choi 21 Sep '11

21 Sep '11

Hello, WebKit/EFL guys. Could anyone know why we use *.c like ewk_view_single.c and ewk_view_tiled.c? Although EFL is based on C, but WebKit is not. If we don't have any reason, I think that we reconcile extensions to remove warning and clear APIs.

3 2

Proposal of WebKit-EFL unit tests
by Krzysztof Czech 21 Sep '11

21 Sep '11

Hello All, I have added today patches with implementation of unit testing framework for WebKit-EFL port. Generally framework based on google's gtest which is already used by some ports in WebKit. Patches numbers are: 68509, 68510, 68511. I would be glad to hear your opinion about it. Regards Krzysztof

1 0

Re: [webkit-efl] HEADS-UP: webkit-efl to require cairo 1.10
by Ryuan Choi 16 Sep '11

16 Sep '11

> WRT the changes in FindCairo.cmake: > > * The libfind_pkg_check_modules macro only accepts 2 parameters. Sorry, It's my mistake. > * You can experiment with the FindPackageHandleStandardArgs module > (which also offers other benefits) to avoid writing the version > message manually. A simple example can be found in [1]. > > [1] https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/e… I agree. But I can't use FindPackageHandleStandardArgs for version error.( I can't open above url. So I referenced FindXXX.cmake in cmake-2.8/Modules/ ) Attached file is different approach. IMO, libfind_pkg_check_modules should be smarter. Best Regards Ryuan Choi.

2 1

Coding style issue in EFL port
by Gyuyoung Kim 16 Sep '11

16 Sep '11

Hello all, As you may know, ewk files are .cpp files, except for two files(ewk_tiled_matrix.c and ewk_tiled_model.c). It means we have to use C++ coding style in .cpp files. However, it looks efl ports are using mixed C and C++ coding style. I think we need to use C++ coding style in efl port except for public APIs. In addition, if port implementation is compiled by C++ compiler, reviewers prefer to use C++ coding style for port implementation, except for platform specific implementation. If nobody oppose my opinion, I'd like to file bugs for this issue, then I prepare patches for that bugs. Because I have lots of interests in coding style since before. In Bug 67705, Kubo suggested that it is better to fix this problem together when other bugs are reviewed. But, I heared that reviewers are concerning this problem now. So, I would like to fix this issue as soon as possible. Furthermore, demarchi already suggested we should use C++ coding style in our implementation. https://bugs.webkit.org/show_bug.cgi?id=67705 Though there are many difficulties, IMHO, we need to use *class* for port implementation like qt port eventually. - Gyuyoung

3 5

Re: [webkit-efl] HEADS-UP: webkit-efl to require cairo 1.10
by Raphael Kubo da Costa 16 Sep '11

16 Sep '11

On Thu, Sep 15, 2011 at 9:28 PM, Ryuan Choi <ryuan.choi(a)samsung.com> wrote: >> Actually, I'm not sure there's going to be someone here to commit this > tomorrow, but this is going to happen no sooner than the beginning of > next week. > > I prepared patch. > I'll create bug within today after internal review. WRT the changes in FindCairo.cmake: * The libfind_pkg_check_modules macro only accepts 2 parameters. * You can experiment with the FindPackageHandleStandardArgs module (which also offers other benefits) to avoid writing the version message manually. A simple example can be found in [1]. [1] https://projects.kde.org/projects/kde/kdelibs/repository/revisions/master/e… -- Raphael Kubo da Costa ProFUSION embedded systems http://profusion.mobi

1 0