- webkit-efl - lists.webkit.org

Re: [webkit-efl] Announcement of Coding Style Change in WebKit EFL port
by Tomasz Morawski 09 Jan '12

09 Jan '12

I think it will better when whole community will change our source according to new/delete operator use not by single person. Maybe it will be better to create a master bug for this task? Due to that remove malloc/calloc/realloc calls and replace it them by smart pointers/new/delete it is not simple task to do this in single patch. There will be need to make some refactorization etc. > Hello Tomasz, > > > Will you replace malloc/calloc/realloc with new / delete ? If you want > to do this, please file a bug. > > > Cheers, > > Gyuyoung > > ------- *Original Message* ------- > > *Sender* : Tomasz Morawski<t.morawski(a)samsung.com> Software > Engineer/Poland R&D Center-Linux (MSD)/삼성전자 > > *Date* : 2012-01-04 17:55 (GMT+09:00) > > *Title* : Re: [webkit-efl] Announcement of Coding Style Change in WebKit > EFL port > > W dniu 03.01.2012 13:27, Raphael Kubo da Costa pisze: > > Tomasz Morawskiwrites: > > > >> W dniu 03.01.2012 12:49, Raphael Kubo da Costa pisze: > >>> Tomasz Morawskiwrites: > >>> > >>>> What about using new/delete operator for memory allocation/free > >>>> everywhere inside internal implementation? For example: > >>>> > >>>> tile = static_cast(malloc(sizeof(Ewk_Tile))); > >>>> > >>>> I think it could be simpler and better to just write: > >>>> > >>>> tile = new EwkTile; > >>> > >>> That'd be really good. Plus using smart pointers wherever possible :) > >> So, since there is general agreement for that, could we add this to > >> EFL coding style? > > > > Sure. Could you add that to the Trac page? > > > It is done. > _______________________________________________ > webkit-efl mailing list > webkit-efl(a)lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-efl >

2 1

Notice about smart class version up.
by JungJik Lee 06 Jan '12

06 Jan '12

Hi, webkit-efl forks. Due to this patch(https://bugs.webkit.org/show_bug.cgi?id=73430) I have increased EWK_VIEW_SMART_CLASS_VERSION up to 4UL. In addtion I have added one more field to EWK_VIEW_SMART_CLASS_INIT. It might cause dependency problems with other application using webkit-EFL port. So I inform you this changes. If you have any problem with this patch, please rebuild your code with latest header files. Thank for your attention. JungJik Lee

1 0

Fwd: Fwd: Fwd: DRT can't be started on EFL.
by Gyuyoung Kim 06 Jan '12

06 Jan '12

1 0

Fwd: Fwd: DRT can't be started on EFL.
by Gyuyoung Kim 06 Jan '12

06 Jan '12

1 0

DRT can't be started on EFL.
by Gyuyoung Kim 06 Jan '12

06 Jan '12

1 0

Re: [webkit-efl] Announcement of Coding Style Change in WebKit EFL port
by Gyuyoung Kim 06 Jan '12

06 Jan '12

1 0

Announcement of Coding Style Change in WebKit EFL port
by Gyuyoung Kim 04 Jan '12

04 Jan '12

3 5

Re: [webkit-efl] Announcement of Coding Style Change in WebKit EFL port
by Gyuyoung Kim 03 Jan '12

03 Jan '12

1 0

I'd like to share webkit2 efl patch
by Ryuan Choi 03 Jan '12

03 Jan '12

Hello WebKit/Efl guys, As you may know, I and some collegues are trying to contribute webkit2 EFL port. Unfortunately, we are developing it in a local because of development schedule and it have many internal implementations and test codes. So, I prepared minimum patche for the first drop. This patch is quite immature to review, so we will upstream this ater refining and fixing issues. If you can't wait them, you can test webkit2/efl using this patch and Minibrowser patch ( https://bugs.webkit.org/show_bug.cgi?id=61850 ) Master bug of webkit2/efl : https://bugs.webkit.org/show_bug.cgi?id=61838 Best Regards, Ryuan Choi

1 0

Re: [webkit-efl] [webkit-dev] Announcement of Coding Style Change in WebKit EFL port
by David Levin 02 Jan '12

02 Jan '12

Feel free to patch the style checker as appropriate. I suspect there may be some changes needed here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checker.p… Best wishes, dave On Tue, Dec 27, 2011 at 11:54 PM, Gyuyoung Kim <gyuyoung.kim(a)samsung.com>wrote: > Hello WebKit folks, > > > As you may know, I have changed the coding style of EFL port via Bug > 68209. This is to eliminate unnecessary difficulties > > that reviewers have experienced when they review EFL bugs, due to EFL > specific coding style. > > > > Bug 68209 - [EFL] Change WebKit EFL coding style > > (https://bugs.webkit.org/show_bug.cgi?id=68209) > > > > Major changes are as below, > > > > 1. Use full variable name instead of abbreviation name. > > 2. Use standard boolean type instead of EFL boolean type. > > 3. Place '*' operator immediately after the data type. (For example, use > char* userAgent. instead of char *userAgent.) > > 4. Use C++ type casting instead of C type casting. > > 5. Remove void parameter from internal functions. > > 6. Use camelCase instead of underbar(_) in variable names. > > > > I made a wiki page for this rule. I will update this page whenever EFL > port coding style guide is changed. > > (http://trac.webkit.org/wiki/EFLWebKitCodingStyle) > > > > To sum up, EFL port adheres to WebKit coding style except for public > header from now. > > (Because public header is used by EFL applications, public header will > continue to follow the coding style rule of EFL.) > > > > We hope that reviewing of EFL port patches will be much easier after this > change. > > > > Happy new year !! > > > > Regards, > > Gyuyoung Kim. > > _______________________________________________ > webkit-dev mailing list > webkit-dev(a)lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >

2 1