[Webkit-unassigned] [Bug 259018] Potentially redundant condition in LocalFrameView style functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 8 16:13:08 PDT 2023


Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
                 CC|                            |ahmad.saleem792 at gmail.com

--- Comment #1 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
Do you want to expand scope of this bug?

I think we can add more checks in 'addScrollableArea' and 'containsScrollableArea' to also assert to confirm we have 'ScrollableArea'.

bool LocalFrameView::addScrollableArea(ScrollableArea* scrollableArea)


bool LocalFrameView::containsScrollableArea(ScrollableArea* scrollableArea) const

    if (!m_scrollableAreas || !scrollableArea)
        return false;

^ Kind of early return, if we don't have scrollableArea.


I think it would make scroll code bit more robust as well.


If not, I am happy to separate PR, above compiles in my local build. :-)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230708/5d2c6bbd/attachment-0001.htm>

More information about the webkit-unassigned mailing list