[Webkit-unassigned] [Bug 259018] New: Potentially redundant condition in LocalFrameView style functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 8 14:18:05 PDT 2023


            Bug ID: 259018
           Summary: Potentially redundant condition in LocalFrameView
                    style functions
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: luke at warlow.dev

horizontalOverscrollBehavior(), verticalOverscrollBehavior() and scrollbarWidthStyle() inside of LocalFrameView have an if (scrollingObject && renderView()) condition before accessing the respective style values.

The renderView() check may be redundant.

scrollbarWidthStyle() has it as it's a copy of the overscrollBehavior functions.

They appear to have it as a left over from when they accessed a function inside of renderView() which was subsequently removed.

Check if this is needed for any of these functions and remove as appropriate.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230708/b6505415/attachment.htm>

More information about the webkit-unassigned mailing list