[Webkit-unassigned] [Bug 250891] New: Do not layout for position changes in RenderWidget::setWidgetGeometry(...)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=250891

            Bug ID: 250891
           Summary: Do not layout for position changes in
                    RenderWidget::setWidgetGeometry(...)
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com
                CC: bfulgham at webkit.org, simon.fraser at apple.com,
                    zalan at apple.com

Created attachment 464573

  --> https://bugs.webkit.org/attachment.cgi?id=464573&action=review

Test Case - Use 'Timeline'

Hi Team,

While going through Blink's commits, I came across another potential win in performance and reducing jank etc.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=158500

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderWidget.cpp#138

```Commit```

Previously, a layout could be caused by a RenderWidget changing
position. For example, an iframe in a scrollable area would get called
to layout if the area scrolled. This occurred because of the the following
callstack:
FrameView calls
RenderWidget::updateWidgetPosition(...) which calls
RenderWidget::updateWidgetGeometry(...) which calls
RenderWidget::setWidgetGeometry(...)

setWidgetGeometry would return true and force a layout if the frame rect
changed position. This should only return true if the frame rect actually
resizes, so this patch updates setWidgetGeometry to return false (not
forcing a layout) if just the frame's position changes.

______

Just wanted to raise to get input whether this is something worth merging or exploring or we have plans to do any other things or this issue is not as bad on WebKit as Blink.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230120/b52aa8f7/attachment.htm>