[Webkit-unassigned] [Bug 250891] Do not layout for position changes in RenderWidget::setWidgetGeometry(...)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 20 03:33:43 PST 2023


https://bugs.webkit.org/show_bug.cgi?id=250891

Ahmad Saleem <ahmad.saleem792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Ahmad Saleem <ahmad.saleem792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #0)
> Created attachment 464573 [details]
> Test Case - Use 'Timeline'
> 
> Hi Team,
> 
> While going through Blink's commits, I came across another potential win in
> performance and reducing jank etc.
> 
> Blink Commit -
> https://src.chromium.org/viewvc/blink?view=revision&revision=158500
> 
> WebKit Source -
> https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderWidget.
> cpp#138
> 
> ```Commit```
> 
> Previously, a layout could be caused by a RenderWidget changing
> position. For example, an iframe in a scrollable area would get called
> to layout if the area scrolled. This occurred because of the the following
> callstack:
> FrameView calls
> RenderWidget::updateWidgetPosition(...) which calls
> RenderWidget::updateWidgetGeometry(...) which calls
> RenderWidget::setWidgetGeometry(...)
> 
> setWidgetGeometry would return true and force a layout if the frame rect
> changed position. This should only return true if the frame rect actually
> resizes, so this patch updates setWidgetGeometry to return false (not
> forcing a layout) if just the frame's position changes.
> 
> ______
> 
> Just wanted to raise to get input whether this is something worth merging or
> exploring or we have plans to do any other things or this issue is not as
> bad on WebKit as Blink.
> 
> Thanks!

Ignore - I think based on this:

https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderWidget.cpp#158

We already have this optimization. Closing this as "RESOLVED INVALID". Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230120/14654e87/attachment.htm>


More information about the webkit-unassigned mailing list