[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260621

--- Comment #16 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to Andres Gonzalez from comment #14)
> (In reply to Joshua Hoffman from comment #9)
> > Created attachment 467419 [details]
> > Patch
> 
> +                return axObject.roleValue() == AccessibilityRole::TabPanel
> && axObject.controllers().size();
> +            });
> +
> +            if (oldFocusedControlledPanelItem) {
> +                auto oldControllers =
> oldFocusedControlledPanelItem->controllers();
> 
> I think that in findAncestor, you only need to find the closest panel
> ancestor, not a panel with controllers. Then if you do find a panel, you can
> check the controllers and update them.
> 
> The rest of the function does the same thing for the new focus. Avoid the
> code duplication, maybe using a lambda. Also account for the case where the
> old panel and the new panel are the same, in which case you only need to
> check for controllers and do updates and notifications only once.
> 

I will refactor that method, thanks for the suggestions!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230825/dcced7ad/attachment.htm>