[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260621

--- Comment #15 from Joshua Hoffman <jhoffman23 at apple.com> ---
Comment on attachment 467419
  --> https://bugs.webkit.org/attachment.cgi?id=467419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467419&action=review

>> Source/WebCore/accessibility/AXObjectCache.cpp:-4112
>> -        case AXSelectedChildrenChanged:
> 
> Sorry to jump on this so late after Chris' comment, but the reason that AXSelectedChildrenChanged didn't just do an updateNodeProperty(*notification.first, AXPropertyName::SelectedChildren) is because selected children determines the `accessibleNameForNode` for listboxes:
> 
> // The Accname specification states that if the name is being calculated for a combobox
> // or listbox inside a labeling element, return the text alternative of the chosen option.
> AccessibilityObject::AccessibilityChildrenVector selectedChildren;
> if (axObject->isListBox())
>     selectedChildren = axObject->selectedChildren();
> 
> And in turn, the accessibleNameForNode is a transitive component of several other properties. And whenever a property's dependency graph gets complex (as in this case), we fallback to updateNode to make sure everything is up-to-date.
> 
> I'm guessing we don't have a testcase for this specific condition (we should add one if not).

Ah I see—will revert this to use updateNode. Let's definitely add that case in a follow-up. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230825/d07fd390/attachment-0001.htm>