[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 25 04:53:17 PDT 2023


--- Comment #12 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Tyler Wilcock from comment #5)
> Comment on attachment 467398 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467398&action=review
> > Source/WebCore/accessibility/AXObjectCache.h:570
> > +    void handleTabOrControlledTabPanelSelected(Node*);
> Any time we add a method here, we need to make sure we add a no-op method to
> the !ENABLE(ACCESSIBILITY) section of this file to avoid breaking the
> Playstation build. See `handleRoleChanged` as an example.

Only for those methods that are actually used when !ENABLE(ACCESSIBILITY), i.e., calls from outside accessibility. No need to have no-op stubs for private or methods that are only used inside accessibility.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230825/d0a4da9f/attachment.htm>

More information about the webkit-unassigned mailing list