[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260621

--- Comment #11 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 467419
  --> https://bugs.webkit.org/attachment.cgi?id=467419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467419&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1559
> +                for (auto& axObject : oldControllers) {

Optional nit, but I think `for (auto& oldController : oldControllers) {` would read better here.

> Source/WebCore/accessibility/AXObjectCache.cpp:1561
> +                    if (auto* parent = axObject->parentObject(); parent->isTabList())

You need to null-check this here when using multi-conditional if-statements. So it should be:

parent && parent->isTabList()

> Source/WebCore/accessibility/AXObjectCache.cpp:1571
> +    if (!newNode)
> +        return;
> +
> +    RefPtr newObject = get(newNode);

I think we can rely on AXObjectCache::get returning nullptr if given a nullptr newNode, so can probably remove the newNode null-check.

> Source/WebCore/accessibility/AXObjectCache.cpp:1588
> +    for (auto& axObject : newControllers) {

Optional nit, but I think `for (auto& newController : newControllers) {` would read better here.

> Source/WebCore/accessibility/AXObjectCache.cpp:1590
> +        if (auto* parent = axObject->parentObject(); parent->isTabList())

Also need a null-check here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230825/b0625c3d/attachment.htm>