[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=260621

--- Comment #4 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to chris fleizach from comment #3)
> Comment on attachment 467398 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=467398&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:1647
> > +    handleTabOrControlledTabPanelSelected(newNode);
> 
> can we make this method take old and new and do the work once?

Yes, however we will have to do the traversal twice inside the method regardless in case the tab panels are controlled by different tabs. 

> > Source/WebCore/accessibility/AXObjectCache.cpp:4081
> > +            if (notification.first->isTabList())
> 
> in this tabList case, we're not actually updating isSelected right? we just
> want SelectedChildren to change?

Yes—I can handle AXChildrenChanged to update that property then (right now, we just do a full updateNode whenever that notification is received.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230823/a9891745/attachment.htm>