[Webkit-unassigned] [Bug 260621] AX: aria-controls-with-tabs fails in ITM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 23 11:54:51 PDT 2023


https://bugs.webkit.org/show_bug.cgi?id=260621

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 467398
  --> https://bugs.webkit.org/attachment.cgi?id=467398
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467398&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1537
> +void AXObjectCache::handleTabOrControlledTabPanelSelected(Node* node)

feel like our naming has been moving to

onTabSelectionChange()

(that may be enough rather than tabOrControlledTab which is pretty wordy)

> Source/WebCore/accessibility/AXObjectCache.cpp:1647
> +    handleTabOrControlledTabPanelSelected(newNode);

can we make this method take old and new and do the work once?

> Source/WebCore/accessibility/AXObjectCache.cpp:4081
> +            if (notification.first->isTabList())

in this tabList case, we're not actually updating isSelected right? we just want SelectedChildren to change?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230823/6728fcfe/attachment.htm>


More information about the webkit-unassigned mailing list