[Webkit-unassigned] [Bug 259621] Potentially remove 'DarkGreyValue' from 'noshade' attribute of HTMLHRElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=259621

--- Comment #6 from Tim Nguyen (:ntim) <ntim at apple.com> ---
(In reply to Ahmad Saleem from comment #5)
> Based on Comment 03, few changes, which work:
> 
> Line 96 (Delete in 'colorAttr') - addHTMLColorToStyle(style,
> CSSPropertyBackgroundColor, value);
> 
> Line 103 (Delete in 'noshadeAttr') -
> style.setProperty(CSSPropertyBackgroundColor, WTFMove(darkGrayValue));
> 
> and change Line 107 (old and now new 105) as following:
> 
>  if (int size = parseHTMLInteger(value).value_or(0); size > 1)
> 
> to
> 
>  if (int size = parseHTMLNonNegativeInteger(value).value_or(0); size > 1)
> 
> _____
> 
> Still figuring out 'parseDimensions' part.

There's a parseHTMLDimension method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20230810/2fdeafc7/attachment.htm>