[Webkit-unassigned] [Bug 232075] [JSC] Implement Date.prototype.toTemporalInstant()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232075

--- Comment #6 from Aditi Singh <asingh at igalia.com> ---
(In reply to Mikhail R. Gadelha from comment #5)
> Hey Aditi, clang is warning about an off-by-one error here:
> 
> DatePrototype.cpp:934:93: warning: implicit conversion from 'long' to
> 'double' changes value from 9223372036854775807 to 9223372036854775808
> [-Wimplicit-const-int-float-conversion]
>     ASSERT(epochMilliseconds >= std::numeric_limits<int64_t>::min() &&
> epochMilliseconds <= std::numeric_limits<int64_t>::max());
>                                                                             
> ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> /home/mgadelha/tools/WebKit/WebKitBuild/Debug/WTF/Headers/wtf/Assertions.h:
> 363:11: note: expanded from macro 'ASSERT'
>     if (!(assertion)) { \
>           ^~~~~~~~~
> 1 warning generated.

Um, I'll look into this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220901/a462baaf/attachment.htm>