[Webkit-unassigned] [Bug 235256] When a “autofilled and obscured” field becomes empty, turn “autofilled and obscured” off

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235256

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drousso at apple.com
 Attachment #454872|review?                     |review+
              Flags|                            |

--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 454872
  --> https://bugs.webkit.org/attachment.cgi?id=454872
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454872&action=review

r=me

> Source/WebCore/html/HTMLInputElement.cpp:1148
>      if (m_isAutoFilledAndViewable && value.isEmpty())
>          setAutoFilledAndViewable(false);

Did you mean to delete this now that it's also done below?

> LayoutTests/fast/forms/input-autofilled-and-obscured.html:34
> +        document.execCommand("Delete");

Could/Should we also tests things like `tf.value = ""` or `tf.form.reset()`?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220316/16968024/attachment.htm>