[Webkit-unassigned] [Bug 235256] When a “autofilled and obscured” field becomes empty, turn “autofilled and obscured” off

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235256

--- Comment #4 from Ellie Epskamp-Hunt <eepskamphunt at apple.com> ---
(In reply to Devin Rousso from comment #3)
> Comment on attachment 454872 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454872&action=review
> 
> r=me
> 
> > Source/WebCore/html/HTMLInputElement.cpp:1148
> >      if (m_isAutoFilledAndViewable && value.isEmpty())
> >          setAutoFilledAndViewable(false);
> 
> Did you mean to delete this now that it's also done below?

I sure did.

> 
> > LayoutTests/fast/forms/input-autofilled-and-obscured.html:34
> > +        document.execCommand("Delete");
> 
> Could/Should we also tests things like `tf.value = ""` or `tf.form.reset()`?

Sure, I can verify that the text field is actually empty at this point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220316/968b60c4/attachment.htm>