[Webkit-unassigned] [Bug 241487] [git-webkit] Failed to write identifier cache to '/home/mcatanzaro/Projects/WebKit/../.git/identifiers.json' Failed to write identifier cache to '/home/mcatanzaro/Projects/WebKit/../.git/identifiers.json'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=241487

--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
(In reply to Jonathan Bedard from comment #5)
> (In reply to Michael Catanzaro from comment #2)
> > ...
> 
> Wait, how is there a newline in there? If `def common_directory(self)` in
> `Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py` isn't
> returning the right thing, that's your problem. And I think a newline from
> `git rev-parse --show-toplevel --git-common-dir` would be pretty unexpected

Oh, you passed two arguments to `git rev-parse`, that's why. `def common_directory` is definitely the culprit, though

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220617/4e1fea4e/attachment.htm>