[Webkit-unassigned] [Bug 242401] AX: Expose suggestion, insertion, deletion roles and attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=242401

--- Comment #8 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 460794
  --> https://bugs.webkit.org/attachment.cgi?id=460794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460794&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:863
> +        if (auto* axObjectCache = node->document().axObjectCache()) {

do we need to make AXObjects here or can we get away by checking attributes on the Node

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1006
> +    [attrString appendAttributedString:[[NSAttributedString alloc] initWithString:text.createNSStringWithoutCopying().get()]];

I think this is going to leak the NSAttributedString. you would need to autorelease it

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4039
> +        if ([attribute isEqualToString: (NSString*)kAXAttributedStringForRangeParameterizedAttribute])

extra space
ing: (NSStr

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:4040
> +            return rangeSet ? [self doAXAttributedStringForRange:range] : nil;

it doesn't look like you're using reangeSet here. do you mean to change range?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220711/7b6284f7/attachment.htm>