[Webkit-unassigned] [Bug 242401] AX: Expose suggestion, insertion, deletion roles and attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=242401

--- Comment #7 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 460794
  --> https://bugs.webkit.org/attachment.cgi?id=460794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460794&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2799
> +    for (AXCoreObject* parent = self.axBackingObject->parentObject(); parent; parent = parent->parentObject()) {

auto* parent

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2801
> +            auto children = parent->children();

I wonder if there's a cleaner way to write this. something like

auto *suggestion = Accessibility::findAncestor(*self.axBackingObject, false, [] (const auto& object) {
        return object.roleValue() == AccessibilityRole::Suggestion;
  });

auto children = suggestion.children();
return children.size() > 1 && children[0].isAncestorOrSelf(self);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220711/1cf1186f/attachment.htm>