[Webkit-unassigned] [Bug 241920] canPlayType and video codec filtering fail for VP8 on Mac with VP8 but not VP9 hardware codecs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=241920

--- Comment #26 from Youssef Soliman <y_soliman at apple.com> ---
Comment on attachment 460741
  --> https://bugs.webkit.org/attachment.cgi?id=460741
Updated patch; confirmed working, but test case gives false positive even if the fix is removed

View in context: https://bugs.webkit.org/attachment.cgi?id=460741&action=review

The fix looks good to me, I recommend following the instructions here: https://github.com/WebKit/WebKit/blob/main/Introduction.md#contributing-code-to-webkit for our new GitHub workflow for landing changes.

You should be able to just undo the commit with `git reset HEAD~1` (assuming this is the latest commit on your working tree), and run `git-webkit pr` to bring these changes to a GitHub PR.

> COMMIT_MESSAGE:8
> +SourceBufferParserWebM::isContentTypeSupported called
> +isVP9DecoderAvailable for both VP9 and VP8 codecs, which caused
> +some older Macs to misreport a failure of VP8 support in
> +HTMLMediaElement.canPlayType, MediaSource.isTypeSupported, and
> +the filtering of video sources based on codec lists.
> +https://bugs.webkit.org/show_bug.cgi?id=241920

You can refer to the format of commit messages here: https://github.com/WebKit/WebKit/blob/main/Introduction.md#commit-messages

> LayoutTests/platform/mac/media/media-can-play-vp8-expected.txt:7
> +EXPECTED (video.canPlayType('video/webm') == 'maybe'), OBSERVED '' FAIL
> +EXPECTED (video.canPlayType('video/webm; codecs=vp8') == 'probably'), OBSERVED '' FAIL

It seems like the expected test case is the failing case.

Try deleting the `-expected.txt` file and re-running the test runner with the flag `--internal-feature AlternateWebMPlayerEnabled=true` and verify that the expected case is a pass.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220707/5e44513b/attachment.htm>