[Webkit-unassigned] [Bug 241920] canPlayType and video codec filtering fail for VP8 on Mac with VP8 but not VP9 hardware codecs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=241920

Brion Vibber <bvibber at wikimedia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #460448|0                           |1
        is obsolete|                            |
 Attachment #460448|review?                     |
              Flags|                            |

--- Comment #25 from Brion Vibber <bvibber at wikimedia.org> ---
Created attachment 460741

  --> https://bugs.webkit.org/attachment.cgi?id=460741&action=review

Updated patch; confirmed working, but test case gives false positive even if the fix is removed

Updated patch, manually confirmed working under alternative WebM player:

* proper commit message format
* changed isVP9DecoderAvailable() to respect the vp9 testing disable override
* test case

However, the test case passes if the actual fix is removed -- it doesn't seem to be using the Cocoa SourceBufferParserWebM from what I can tell, and I'm not sure if it's possible to enable the alternative WebM backend at runtime in a test, or even enable it globally for the test run.

I might just be missing a key bit in setting up the settings for the tests, if so I'm happy to do a final rev on the patch. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220707/cbe56724/attachment-0001.htm>