[Webkit-unassigned] [Bug 235444] [GTK][STABLE] More missing headers and preprocessor guards for non-unified 2.34.4 build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 17:28:37 PST 2022


--- Comment #10 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Dennis Nezic from comment #9)
> Also, at least one of my fixes (the ones involving the *TransientZoom
> functions, is broken because I had USE_OPENGL_OR_ES=OFF ... is that not
> public/"allowed" either?

That one is public: if the build fails, it's a bug. The rest I've said above still applies.

> And I think all the other preprocessor guards that I added are just adding
> to what already exists ... if my ones aren't worth it, than the existing
> ones shouldn't be either. They literally do the same thing - someone just
> forgot to maintain them over time.

Again, these guards are needed in *cross-platform files* but not our platform-specific files.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220124/d161256a/attachment-0001.htm>

More information about the webkit-unassigned mailing list