[Webkit-unassigned] [Bug 235459] WebKit fails to build - error: 'webrtc/rtc_base/network.h' file not found
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 21 16:54:50 PST 2022
https://bugs.webkit.org/show_bug.cgi?id=235459
--- Comment #4 from Michael Saboff <msaboff at apple.com> ---
(In reply to Mark Lam from comment #3)
> Comment on attachment 449705 [details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449705&action=review
>
> I'm not super familiar with the plumbing of all the settings variables, but
> this patch LGTM.
>
> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:27
> > + RELATIVE_PATH_FROM_SYMLINK_TO_ROOT=$(echo "${PUBLIC_FOLDER_PREFIX}" | sed -E -e "s/\/[a-zA-Z0-9_]+/..\//g" -e "s/\/$//")
>
> Why is this "s/\/$//" needed?
To eliminate any trailing '/'.
> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:28
> > + SYMLINK_VALUE="${RELATIVE_PATH_FROM_SYMLINK_TO_ROOT}${INSTALL_FOLDER_PREFIX}/${TARGET}"
>
> nit: call this SYMLINK_TARGET instead?
This follows some the name of other similar scripts.
> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:52
> > + if [[ ! -d ${SYSTEM_PUBLIC_HEADER_PREFIX} ]]; then
> > + mkdir -p ${SYSTEM_PUBLIC_HEADER_PREFIX}
> > + fi
>
> Can't you do this just once outside of the for loop? The only difference is
> that moving this out would create this directory even if HEADER_FOLDER_LIST
> is empty. But we know it'll never be empty, right?
>
> > Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:64
> > + if [[ ! -d ${SYSTEM_PUBLIC_LIBRARY_PREFIX} ]]; then
> > + mkdir -p ${SYSTEM_PUBLIC_LIBRARY_PREFIX}
> > + fi
>
> Ditto. Do this outside the for loop?
I moved both of these to above the loop.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220122/779129aa/attachment.htm>
More information about the webkit-unassigned
mailing list