[Webkit-unassigned] [Bug 235385] [XCBuild] Build via the workspace with USE_WORKSPACE=YES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235385

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #449529|review?                     |review+
              Flags|                            |

--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 449529
  --> https://bugs.webkit.org/attachment.cgi?id=449529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449529&action=review

> Makefile.shared:153
> +ifeq ($(SKIP_INSTALLSRC),YES)
> +	@true
> +else

I don't understand why this is needed. `make installsrc` is only invoked in very specific circumstances, and when it is, it's really necessary. So it's not clear to me how it would be invoked from the root makefile with workspace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220120/1dacadc6/attachment-0001.htm>