[Webkit-unassigned] [Bug 235385] [XCBuild] Build via the workspace with USE_WORKSPACE=YES

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235385

--- Comment #6 from Elliott Williams <emw at apple.com> ---
(In reply to Alexey Proskuryakov from comment #5)
> > Makefile.shared:153
> > +ifeq ($(SKIP_INSTALLSRC),YES)
> > +	@true
> > +else
> 
> I don't understand why this is needed. `make installsrc` is only invoked in
> very specific circumstances, and when it is, it's really necessary. So it's
> not clear to me how it would be invoked from the root makefile with
> workspace.

Tools/Makefile is the only place that sets this, to match its current `installsrc` rule. If we'd never actually try to installsrc from Tools/, maybe it's safe to delete this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220120/4b0c86e6/attachment.htm>