[Webkit-unassigned] [Bug 234841] AX: Make more tests async to pass in isolated tree mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 12:24:55 PST 2022


Tyler Wilcock <tyler_w at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |tyler_w at apple.com

--- Comment #4 from Tyler Wilcock <tyler_w at apple.com> ---
In general, we're trying to only make tests async when necessary. If a test has only static content, it *should* pass in isolated tree mode without the test being made async. The only time a test should need to be async is if the test changes elements dynamically, i.e. via JavaScript. Otherwise we may be masking real isolated tree bugs.

It seems like a lot of the changes to tests in this patch only add:

window.jsTestIsAsync = true;

setTimeout(function() {

    ...test logic moved inside here...

}, 0);

It surprises me that this makes the tests pass in isolated tree mode where they didn't before. Do you know why this could be?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220104/59308a0d/attachment.htm>

More information about the webkit-unassigned mailing list