[Webkit-unassigned] [Bug 234841] AX: Make more tests async to pass in isolated tree mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 23:14:19 PST 2022


--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Tyler Wilcock from comment #4)
> In general, we're trying to only make tests async when necessary.

I agree, I'm converting only the ones that are failing.

> If a test
> has only static content, it *should* pass in isolated tree mode without the
> test being made async. The only time a test should need to be async is if
> the test changes elements dynamically, i.e. via JavaScript.

This is no longer the ase since r287533, see my comment in https://bugs.webkit.org/show_bug.cgi?id=234739#c5. It was because of a side effect of triggering a layout while populating the isolated tree.

> Otherwise we may
> be masking real isolated tree bugs.
> It seems like a lot of the changes to tests in this patch only add:
> window.jsTestIsAsync = true;
> setTimeout(function() {
>     ...test logic moved inside here...
>     finishJSTest();
> }, 0);
> It surprises me that this makes the tests pass in isolated tree mode where
> they didn't before. Do you know why this could be?

Yes, in many cases the ax wrappers haven't been attached to the isolated object yet.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220105/595f749f/attachment.htm>

More information about the webkit-unassigned mailing list