[Webkit-unassigned] [Bug 244128] Add experimental feature to disable image animations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=244128

--- Comment #19 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to Said Abou-Hallawa from comment #18)

> Can you split this patch into three patches: one for BitmapImage, another
> for the SVG image and the third for the <model> element?
> 

Yes! I will update this one to just do BitmapImages, and have those other two follow. 

> > Source/WebCore/html/HTMLImageElement.cpp:777
> > +void HTMLImageElement::playAnimation()
> 
> What does playAnimation() mean? Does it mean resume or restart?

It means resume—I'll be more explicit and rename it. 

> > Source/WebCore/html/HTMLImageElement.cpp:779
> > +    if (auto* image = cachedBitmapImage()) {
> 
> Why do we care about BitmapImage only here? The image can be SVGImage which
> may have animated elements.

Understood. In the SVG patch this will handle SVGImages. 

> > Source/WebCore/platform/graphics/BitmapImage.cpp:70
> > +void BitmapImage::updateFromDocument(const Document& document)
> 
> This is layering violation. We should not be accessing Document in the
> platform directory.

Gotcha. I'll revert this back to updateFromSettings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220825/4e412416/attachment.htm>