[Webkit-unassigned] [Bug 244128] Add experimental feature to disable image animations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=244128

--- Comment #18 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 461844
  --> https://bugs.webkit.org/attachment.cgi?id=461844
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461844&action=review

> COMMIT_MESSAGE:7
> +This patch adds a new experimental AX feature, which when enabled, disables image animations. This includes regular bitmap images, background images, SVG animations, and support for the <model> element. Additionally, we provide new interfaces to control animations at the page and individual image level.

Can you split this patch into three patches: one for BitmapImage, another for the SVG image and the third for the <model> element?

> Source/WebCore/html/HTMLImageElement.cpp:777
> +void HTMLImageElement::playAnimation()

What does playAnimation() mean? Does it mean resume or restart?

> Source/WebCore/html/HTMLImageElement.cpp:779
> +    if (auto* image = cachedBitmapImage()) {

Why do we care about BitmapImage only here? The image can be SVGImage which may have animated elements.

> Source/WebCore/platform/graphics/BitmapImage.cpp:70
> +void BitmapImage::updateFromDocument(const Document& document)

This is layering violation. We should not be accessing Document in the platform directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220824/ae100252/attachment-0001.htm>