[Webkit-unassigned] [Bug 238797] [GTK][WPE] RemoteInspector add support for IPv6

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238797

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 456686
  --> https://bugs.webkit.org/attachment.cgi?id=456686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456686&action=review

>> Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp:83
>> +        inspectorServerAddress.reset(g_strdup_printf("%s:%u", host.get(), inspectorPort));
> 
> Is there any reason why cannot use g_inet_address_to_string() always here
> instead of checking the address family and performing the conversion by
> hand? A quick test shows that it should work as inteded:

Yes, g_inet_address_to_string() always returns the address without the square brackets. We could create a new GSocketInetAddress with the required port and then call to_string, but I just avoided to create another GObject.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220405/22276f56/attachment.htm>