[Webkit-unassigned] [Bug 238797] [GTK][WPE] RemoteInspector add support for IPv6

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=238797

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 456686
  --> https://bugs.webkit.org/attachment.cgi?id=456686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456686&action=review

> Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp:83
> +        inspectorServerAddress.reset(g_strdup_printf("%s:%u", host.get(), inspectorPort));

Is there any reason why cannot use g_inet_address_to_string() always here
instead of checking the address family and performing the conversion by
hand? A quick test shows that it should work as inteded:

>>> from gi.repository import Gio
>>> Gio.InetSocketAddress.new_from_string("::0", 8000).to_string()
'[::]:8000'
>>> Gio.InetSocketAddress.new_from_string("0.0.0.0", 8000).to_string()
'0.0.0.0:8000'
>>>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220405/f981e28a/attachment-0001.htm>