[Webkit-unassigned] [Bug 204276] Implement the 'ic' unit from CSS Values 4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=204276

--- Comment #21 from Kiet Ho <tho22 at apple.com> ---
Comment on attachment 439032
  --> https://bugs.webkit.org/attachment.cgi?id=439032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439032&action=review

>> Source/WebCore/css/CSSPrimitiveValue.cpp:1051
>> +        return formatNumberValue("ic");
> 
> The "CHS"  vs "ch" and "ICS" vs "ic" is confusing. Why aren't the unit types CSS_CH and CSS_IC?

I have no explanation other than I just followedcthe existing convention for CSS_CHS. I'll rename CSS_ICS to CSS_IC. As for CSS_CHS, maybe that's for another patch.

>> LayoutTests/imported/w3c/ChangeLog:8
>> +
> 
> Please describe why you had to change the WPT.

Yeah, I'll fill in the changelogs after everything else checks out.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210923/edb14f49/attachment.htm>