[Webkit-unassigned] [Bug 204276] Implement the 'ic' unit from CSS Values 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 23 11:50:13 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=204276

--- Comment #20 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 439032
  --> https://bugs.webkit.org/attachment.cgi?id=439032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439032&action=review

> Source/WebCore/css/CSSPrimitiveValue.cpp:1051
>      case CSSUnitType::CSS_CHS:
>          return formatNumberValue("ch");
> +    case CSSUnitType::CSS_ICS:
> +        return formatNumberValue("ic");

The "CHS"  vs "ch" and "ICS" vs "ic" is confusing. Why aren't the unit types CSS_CH and CSS_IC?

> LayoutTests/imported/w3c/ChangeLog:8
> +

Please describe why you had to change the WPT.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210923/79e4d846/attachment.htm>


More information about the webkit-unassigned mailing list