[Webkit-unassigned] [Bug 229556] AX: Make PDFs loaded via <embed> accessible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229556

--- Comment #21 from Tyler Wilcock <tyler_w at apple.com> ---
(In reply to Andres Gonzalez from comment #20)
> (In reply to Tyler Wilcock from comment #19)
> > > I would suggest getting rid of the bools and changing this logic to:
> > While your suggestion is fair, it wouldn’t work for the thing we care most
> > about in this bug, which is the PDFLayerController. It has conflicting
> > implementations for `accessibilityIsIgnored` and `isAccessibilityElement`
> > that would cause it to get ignored with your suggested change:
> > 
> > 

// We need this here as well until rdar://31454793 is resolved
> > - (BOOL)accessibilityIsIgnored
> > {
> > 	return YES;
> > }
> > 
> > - (BOOL)isAccessibilityElement
> > {
> > 	return YES;
> > }
> 
> It is not necessarily a conflict that an AXElment is also ignored. Why is it
> a problem that PDFLayerController is ignored?

It may not a problem in some cases, but it seems to be here. I tested your suggestion which results in the PDFLayerController being ignored, which in turn makes the PDF unable to be hit by hit test via accesstool, the Accessibility Inspector, or my layout test.

Here's the hierarchy, if it's useful:

Embed element renderWidgetChildren
> WKPDFPluginAccessibilityObject
>> PDFLayerController
>>> PDFAccessibilityNodePage
>>>> more PDF nodes all the way down

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210910/7d561c3b/attachment.htm>