[Webkit-unassigned] [Bug 225850] [PATCH] fix webkitgtk build on macOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225850

--- Comment #12 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 437417
  --> https://bugs.webkit.org/attachment.cgi?id=437417
Combined patch (revised)

View in context: https://bugs.webkit.org/attachment.cgi?id=437417&action=review

Patch looks fine, but the change-logs have a formatting that don't follow the standard we usually use. See my comments

> Source/WTF/ChangeLog:6
> +        Define HAVE_AUDIT_TOKEN only for Cocoa backend to fix webkitgtk on
> +        macOS.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=225850

Please, don't wrap the subject lines and don't leave a blank line between the subject and the bug number.
Also, please use the same subject on all the changelog files.

For example use this:

Fix WebKitGTK build on MacOS
https://bugs.webkit.org/show_bug.cgi?id=225850

Reviewed by NOBODY (OOPS!).

Define HAVE_AUDIT_TOKEN only for Cocoa backend to fix webkitgtk on macOS.

[...]

> Source/WebKit/ChangeLog:11
> +        Don't require availability of MSG_NOSIGNAL to fix webkitgtk build on
> +        macOS.
> +
> +        Streamline conditionals for consistency between definitions and
> +        implementations to allow compiling webkitgtk on macOS.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=225850
> +
> +        Reviewed by NOBODY (OOPS!).

This changelog should kept the same title than the other changelog, and the explanation or the details comes after the "reviewed by" line. For example:


Fix WebKitGTK build on MacOS
https://bugs.webkit.org/show_bug.cgi?id=225850

Reviewed by NOBODY (OOPS!).

Don't require availability of MSG_NOSIGNAL to fix webkitgtk build on macOS.
Streamline conditionals for consistency between definitions and implementations to allow compiling webkitgtk on macOS. 

[...]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210906/dd5c50bf/attachment-0001.htm>