[Webkit-unassigned] [Bug 225850] [PATCH] fix webkitgtk build on macOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=225850

--- Comment #13 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 437405
  --> https://bugs.webkit.org/attachment.cgi?id=437405
Combined patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437405&action=review

>> Source/WebKit/ChangeLog:8
>> +        https://bugs.webkit.org/show_bug.cgi?id=225850
> 
> There should be one blank line in the ChangeLog above the URL.

I think this is incorrect. Above the url it should be the subject and not a blank line.
The formatting of ChangeLog files is:

"""
Subject (same subject for all the changelog entries, and without wrapping long lines)
https://bugs.webkit.org/show_bug.cgi?id=${bugnumber}

Reviewed by NOBODY (OOPS!).

Explanation of what this patch does.

* List of files modified
"""

Check how other changelog entries are written in case of doubt.

The tool Tools/Scripts/prepare-ChangeLog can help to automate this.
You can pass to it the bug number, for example: Tools/Scripts/prepare-ChangeLog -b 225850

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210906/2235b887/attachment.htm>