[Webkit-unassigned] [Bug 229337] GLContextGLX.cpp may sometimes fail build because of X11 include files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229337

--- Comment #13 from Daniel Kolesa <dkolesa at igalia.com> ---
(In reply to Fujii Hironori from comment #12)
> WebKit has a lot of #undef in WTF and WebCore layer for this issue
> For example,
> https://github.com/WebKit/WebKit/blob/
> bb27304754d0bb686fc3ddfccc42fb8ec1f14d62/Source/WTF/wtf/Threading.h#L64,L68
> If you can solve the issue completely by @no-unify approach, we no longer
> need the #undef.
> 
> I think @no-unify approach can't solve the issue completely  because
> #include order is ruled by WebKit coding style.
> If a header defining None or True are included after X11 header, it can't
> compile. We need #undef. @no-unify approach isn't a good idea.
> I think we should add X11Headers.h to include all X11 headers we need.

this is never really a problem for the problematic file in this case, because the X11 headers are included last, and it's a source file - which was my point all along, if you eliminate it being unified with another source file, there should be no problem anymore (your concern would only be a problem if the file itself was a header, or if we didn't control the include order of headers)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211101/78e849ce/attachment.htm>