[Webkit-unassigned] [Bug 229337] GLContextGLX.cpp may sometimes fail build because of X11 include files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229337

--- Comment #12 from Fujii Hironori <Hironori.Fujii at sony.com> ---
WebKit has a lot of #undef in WTF and WebCore layer for this issue
For example, https://github.com/WebKit/WebKit/blob/bb27304754d0bb686fc3ddfccc42fb8ec1f14d62/Source/WTF/wtf/Threading.h#L64,L68
If you can solve the issue completely by @no-unify approach, we no longer need the #undef.

I think @no-unify approach can't solve the issue completely  because #include order is ruled by WebKit coding style.
If a header defining None or True are included after X11 header, it can't compile. We need #undef. @no-unify approach isn't a good idea.
I think we should add X11Headers.h to include all X11 headers we need.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211029/c1a8c148/attachment-0001.htm>